Skip to content

Conversation

@tobiashuste
Copy link
Member

@tobiashuste tobiashuste commented Jan 16, 2025

The fleeting-plugin-openstack project changed it's release naming scheme to include a leading v. The binary itself still makes use of the version without a leading v requiring us to update our role behavior.

The implementation should work for both versions using the previous naming scheme as well as the new one.

@tobiashuste tobiashuste added the bug Something isn't working label Jan 16, 2025
@tobiashuste tobiashuste self-assigned this Jan 16, 2025
@tobiashuste tobiashuste requested a review from a team as a code owner January 16, 2025 07:40
@github-actions github-actions bot added the gitlab_runner Related to hifis.toolkit.gitlab_runner role label Jan 16, 2025
@tobiashuste tobiashuste force-pushed the fleeting-plugin-download-url branch from 103521e to 18dfb1c Compare January 16, 2025 07:56
@tobiashuste tobiashuste force-pushed the fleeting-plugin-download-url branch from 18dfb1c to cdc58aa Compare January 16, 2025 08:03
@tobiashuste tobiashuste force-pushed the fleeting-plugin-download-url branch from 0ef01bd to 4a99c16 Compare January 16, 2025 08:19
@tobiashuste tobiashuste requested a review from Normo January 16, 2025 08:21
Copy link
Member

@Normo Normo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tobiashuste 👍

@Normo Normo merged commit cdf12d1 into hifis-net:main Jan 16, 2025
11 checks passed
@tobiashuste tobiashuste deleted the fleeting-plugin-download-url branch January 16, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gitlab_runner Related to hifis.toolkit.gitlab_runner role

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants